Services4User review

[Nicolas Williams]

On Fri, Aug 21, 2009 at 11:03:48AM +0200, Luke Howard wrote:
> 
> On 21/08/2009, at 10:47 AM, Luke Howard wrote:
> 
> >>
> >>OM_uint32
> >>gss_add_cred_with_{name,cred}(
> >>	OM_uint32		*minor_status,
> >>	const gss_cred_id_t	impersonator_cred_handle,
> >>	const gss_cred_id_t	input_cred_handle,
> >
> >
> >Would it be more consistent for input_cred_handle to be before
> >impersonator_cred_handle?
> 
> Also, input_cred_handle should not be const, I think?

Well, if there's no output_cred_handle pointer then gss_add_cred() will
modify the given input_cred_handle (one of the two must be provided).
So input_cred_handle is not input-only.  But as far as C is concerned
that doesn't matter, so const is OK, though misleading.