svn rev #22474: trunk/src/lib/krb5/krb/

[epeisach@MIT.EDU]

http://mv.ezproxy.com.ezproxyberklee.flo.org/fisheye/changelog/krb5/?cs=22474
Commit By: epeisach
Log Message:
ticket: 6541
subject: Fix memory leak in k5_pac_verify_server_checksum

k5_pac_verify_server_checksum was leaking memory when the checksum was valid.

t_pac.c: Fix memory leak by forgetting to release memory.




Changed Files:
U   trunk/src/lib/krb5/krb/pac.c
U   trunk/src/lib/krb5/krb/t_pac.c
Modified: trunk/src/lib/krb5/krb/pac.c
===================================================================
--- trunk/src/lib/krb5/krb/pac.c	2009-07-30 17:12:20 UTC (rev 22473)
+++ trunk/src/lib/krb5/krb/pac.c	2009-07-30 17:22:28 UTC (rev 22474)
@@ -547,8 +547,10 @@
 
     ret = krb5_c_verify_checksum(context, server, KRB5_KEYUSAGE_APP_DATA_CKSUM,
 				 &pac_data, &checksum, &valid);
+
+    free(pac_data.data);
+
     if (ret != 0) {
-	free(pac_data.data);
 	return ret;
     }
 

Modified: trunk/src/lib/krb5/krb/t_pac.c
===================================================================
--- trunk/src/lib/krb5/krb/t_pac.c	2009-07-30 17:12:20 UTC (rev 22473)
+++ trunk/src/lib/krb5/krb/t_pac.c	2009-07-30 17:22:28 UTC (rev 22474)
@@ -220,6 +220,8 @@
         if (ret)
             err(context, ret, "krb5_pac_verify 4");
         
+        krb5_free_data_contents(context, &data);
+
         krb5_pac_free(context, pac2);
     }